Open
Conversation
d6d2c3c to
900e933
Compare
1558ae7 to
a7a1441
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 93.01% 92.91% -0.11%
==========================================
Files 21 21
Lines 2435 2470 +35
==========================================
+ Hits 2265 2295 +30
- Misses 170 175 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Some initial remarks with these changes, some projects fail to build:
|
Miauwkeru
requested changes
Oct 2, 2025
| return name | ||
|
|
||
| def _add_attr(self, name: str, value: Any, replace: bool = False) -> None: | ||
| if not replace and (name in self.__dict__ and self.__dict__[name] != value): |
Contributor
There was a problem hiding this comment.
Suggested change
| if not replace and (name in self.__dict__ and self.__dict__[name] != value): | |
| if not replace and (self.__dict__.get(name) != value): |
Or is the overhead of the function call higher?
| @@ -79,32 +79,43 @@ def generate_cstruct_stub(cs: cstruct, module_prefix: str = "", cls_name: str = | |||
|
|
|||
Contributor
There was a problem hiding this comment.
There is an issue on L174/L185 where it now generates structures multiple times due to looking into typedefs instead of types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113
Some micro benchmarks:
Before:
After: